release-1.8 Issue #6921: Unbreak compute engine url signing #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tiger Kaovilai <[email protected]> Remove doc assumptions that `GKE Workload Identity` = `Workload Identity Federation` and cannot generate signed URLs Signed-off-by: Tiger Kaovilai <[email protected]>
kaovilai
force-pushed
the
alwaysSignUrl-r1.8
branch
from
933c3eb to
a69371d
Compare
Codecov Report
@@ Coverage Diff @@
## release-1.8 #159 +/- ##
===============================================
- Coverage 29.26% 29.15% -0.12%
===============================================
Files 3 3
Lines 516 518 +2
===============================================
Hits 151 151
- Misses 353 355 +2
Partials 12 12
|
sseago
approved these changes
Oct 16, 2023
shubham-pampattiwar
approved these changes
Oct 16, 2023
shubham-pampattiwar
merged commit a0d6464
into
vmware-tanzu:release-1.8
2 checks passed
|
Hi there 👋, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherrypicks #158
Signed-off-by: Tiger Kaovilai [email protected]
Remove doc assumptions that
GKE Workload Identity=Workload Identity Federationand cannot generate signed URLsSigned-off-by: Tiger Kaovilai [email protected]