Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue#7731: add endpoint for GCP objectstore client #184

Merged
merged 6 commits into from
Oct 28, 2024
Merged

issue#7731: add endpoint for GCP objectstore client #184

merged 6 commits into from
Oct 28, 2024
+18 −6

Conversation

chrislinan
Copy link
Contributor

No description provided.

@chrislinan chrislinan mentioned this pull request May 9, 2024
Open
blackpiglet
blackpiglet previously approved these changes May 9, 2024
View reviewed changes
@blackpiglet blackpiglet dismissed their stale review May 9, 2024 09:09

Remove accidental approve.

@blackpiglet
Copy link
Collaborator

@chrislinan
The go module configuration is not update to date.

@chrislinan chrislinan requested a review from blackpiglet May 10, 2024 02:04
@blackpiglet
Copy link
Collaborator

Thanks for the update.
The code change looks good, but the Velero v1.14.0 waits for its RC.
Could we put this PR on hold until the GCP plugin's corresponding release is cut?

@chrislinan
Copy link
Contributor Author

Thanks for the update. The code change looks good, but the Velero v1.14.0 waits for its RC. Could we put this PR on hold until the GCP plugin's corresponding release is cut?

Yes, we could hold this PR. And I will open another PR for Velero to update documents and add this feature in docs.

@chrislinan chrislinan requested a review from anshulahuja98 May 13, 2024 03:16
@blackpiglet
Copy link
Collaborator

@chrislinan
Please help to squash the commits.

@anshulahuja98
Copy link

@blackpiglet can you trigger the CI
I don't have permission on this repo

@chrislinan
Copy link
Contributor Author

Hi @blackpiglet , Could you help review this PR? Thanks a lot.

@anshulahuja98
Copy link

@chrislinan - can you also make any relevant docs changes?

@anshulahuja98
Copy link

I don't have approver access on this repo. the PR LGTM otherwise.

linan-0115 and others added 5 commits October 21, 2024 17:01
@linan-0115
add endpoint for GCP objectstore client
3ee7955 
add endpoint for GCP objectstore client

Signed-off-by: William Li <[email protected]>

sign off

Signed-off-by: William Li <[email protected]>

format code

Signed-off-by: William Li <[email protected]>

remove wrong files

Signed-off-by: William Li <[email protected]>

update go module

Signed-off-by: William Li <[email protected]>

change endpoint key name

Signed-off-by: William Li <[email protected]>

update go module

Signed-off-by: William Li <[email protected]>
@blackpiglet @linan-0115
Add changelog for v1.10.0 and bump Velero tag.
590058a 
Signed-off-by: Xun Jiang <[email protected]>
Signed-off-by: William Li <[email protected]>
@blackpiglet @linan-0115
Bump depending velero version to latest main commit.
e6d162b 
Signed-off-by: Xun Jiang <[email protected]>
Signed-off-by: William Li <[email protected]>
@blackpiglet @linan-0115
Add changelog and update README for v1.11.0.
9d76263 
Signed-off-by: Xun Jiang <[email protected]>
Signed-off-by: William Li <[email protected]>
@linan-0115
add document for storeEndpoint
0583fe7 
Signed-off-by: William Li <[email protected]>
@chrislinan
Copy link
Contributor Author

chrislinan commented Oct 22, 2024 •
edited
Loading

@chrislinan - can you also make any relevant docs changes?

Yes, I made some changes in backupstoragelocation.md

@chrislinan
Copy link
Contributor Author

Hi @ywk253100 @blackpiglet @shubham-pampattiwar Could you help review this PR? Thanks.

@kaovilai
Copy link
Member

I'm assuming they will review after v1.15 GA which is soon.

@blackpiglet
Copy link
Collaborator

I'm assuming they will review after v1.15 GA which is soon.

Yeah, thanks, Tiger.

@chrislinan Sorry for the late response. I was working closely on the Velero v1.15.0 RC and GA.
Because we didn't consider testing this change in the v1.15.0 function test, it's better to merge this PR after new branch cut.

@blackpiglet blackpiglet requested a review from sseago October 28, 2024 07:19
@sseago sseago merged commit 5c34921 into vmware-tanzu:main Oct 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blackpiglet blackpiglet blackpiglet approved these changes

@anshulahuja98 anshulahuja98 anshulahuja98 approved these changes

@sseago sseago sseago approved these changes

@shubham-pampattiwar shubham-pampattiwar Awaiting requested review from shubham-pampattiwar

@ywk253100 ywk253100 Awaiting requested review from ywk253100

Assignees

@chrislinan chrislinan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chrislinan @blackpiglet @anshulahuja98 @kaovilai @sseago @linan-0115