Refactor the Azure plugin #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywk253100
force-pushed
the
230613_refactor
branch
from
e039c2c to
9586ed2
Compare
3 tasks
ywk253100
force-pushed
the
230613_refactor
branch
2 times, most recently
from
69fb023 to
5ab89e1
Compare
Both Kopia repository and Azure plugin need to interact with Azure storage. In order to keep in sync with the new features for both these two places and remove duplicated code, PR vmware-tanzu/velero#6686 makes the common code as util functions in Velero repository. This commit refactors the Azure plugin based on these util functions. Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
ywk253100
force-pushed
the
230613_refactor
branch
from
5ab89e1 to
b7732e8
Compare
Codecov Report
@@ Coverage Diff @@
## main #206 +/- ##
==========================================
+ Coverage 13.46% 15.92% +2.46%
==========================================
Files 4 3 -1
Lines 698 496 -202
==========================================
- Hits 94 79 -15
+ Misses 601 414 -187
Partials 3 3
|
blackpiglet
reviewed
Sep 20, 2023
| github.com/stretchr/testify v1.8.2 | ||
| github.com/vmware-tanzu/velero v0.0.0-20230727074327-a6d79fc272a2 | ||
| github.com/stretchr/testify v1.8.4 | ||
| github.com/vmware-tanzu/velero v1.10.0-rc.1.0.20230920021852-d3e5bb745144 |
There was a problem hiding this comment.
Is there a reason to reference a Velero RC tag?
There was a problem hiding this comment.
This is generated by go cmd automatically when running go get github.com/vmware-tanzu/velero@main.
The tag isn't important as this is a pseudo version and we'll update it to the GA version when making the final release
Lyndon-Li
approved these changes
Sep 21, 2023
blackpiglet
approved these changes
Sep 21, 2023
This was referenced Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both Kopia repository and Azure plugin need to interact with Azure storage. In order to keep in sync with the new features for both these two places and remove duplicated code, PR vmware-tanzu/velero#6686 makes the common code as util functions in Velero repository.
This commit refactors the Azure plugin based on these util functions.