Skip to content

Commit

Permalink
Merge pull request #7260 from blackpiglet/rename_volumeinfo_metadata_…
Browse files Browse the repository at this point in the history
…file

Rename volumeinfo metadata file.
  • Loading branch information
reasonerjt authored Jan 3, 2024
2 parents f6dfa8e + 08dedd8 commit 6e641f4
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion pkg/persistence/object_store_layout.go
Original file line number Diff line number Diff line change
Expand Up @@ -130,5 +130,5 @@ func (l *ObjectStoreLayout) getBackupResultsKey(backup string) string {
}

func (l *ObjectStoreLayout) getBackupVolumeInfoKey(backup string) string {
return path.Join(l.subdirs["backups"], backup, fmt.Sprintf("%s-volumeinfos.json.gz", backup))
return path.Join(l.subdirs["backups"], backup, fmt.Sprintf("%s-volumeinfo.json.gz", backup))
}
14 changes: 7 additions & 7 deletions pkg/persistence/object_store_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ func TestPutBackup(t *testing.T) {
"backups/backup-1/backup-1-volumesnapshots.json.gz",
"backups/backup-1/backup-1-itemoperations.json.gz",
"backups/backup-1/backup-1-resource-list.json.gz",
"backups/backup-1/backup-1-volumeinfos.json.gz",
"backups/backup-1/backup-1-volumeinfo.json.gz",
},
},
{
Expand All @@ -274,7 +274,7 @@ func TestPutBackup(t *testing.T) {
"prefix-1/backups/backup-1/backup-1-volumesnapshots.json.gz",
"prefix-1/backups/backup-1/backup-1-itemoperations.json.gz",
"prefix-1/backups/backup-1/backup-1-resource-list.json.gz",
"prefix-1/backups/backup-1/backup-1-volumeinfos.json.gz",
"prefix-1/backups/backup-1/backup-1-volumeinfo.json.gz",
},
},
{
Expand Down Expand Up @@ -320,7 +320,7 @@ func TestPutBackup(t *testing.T) {
"backups/backup-1/backup-1-volumesnapshots.json.gz",
"backups/backup-1/backup-1-itemoperations.json.gz",
"backups/backup-1/backup-1-resource-list.json.gz",
"backups/backup-1/backup-1-volumeinfos.json.gz",
"backups/backup-1/backup-1-volumeinfo.json.gz",
},
},
{
Expand All @@ -339,7 +339,7 @@ func TestPutBackup(t *testing.T) {
"backups/backup-1/backup-1-podvolumebackups.json.gz",
"backups/backup-1/backup-1-volumesnapshots.json.gz",
"backups/backup-1/backup-1-resource-list.json.gz",
"backups/backup-1/backup-1-volumeinfos.json.gz",
"backups/backup-1/backup-1-volumeinfo.json.gz",
},
},
}
Expand Down Expand Up @@ -773,7 +773,7 @@ func TestGetDownloadURL(t *testing.T) {
name: "",
targetName: "my-backup",
expectedKeyByKind: map[velerov1api.DownloadTargetKind]string{
velerov1api.DownloadTargetKindBackupVolumeInfos: "backups/my-backup/my-backup-volumeinfos.json.gz",
velerov1api.DownloadTargetKindBackupVolumeInfos: "backups/my-backup/my-backup-volumeinfo.json.gz",
},
},
}
Expand Down Expand Up @@ -1116,7 +1116,7 @@ func TestGetBackupVolumeInfos(t *testing.T) {

require.NoError(t, json.NewEncoder(gzw).Encode(tc.volumeInfo))
require.NoError(t, gzw.Close())
harness.objectStore.PutObject(harness.bucket, "backups/test-backup/test-backup-volumeinfos.json.gz", obj)
harness.objectStore.PutObject(harness.bucket, "backups/test-backup/test-backup-volumeinfo.json.gz", obj)
}

if tc.volumeInfoStr != "" {
Expand All @@ -1126,7 +1126,7 @@ func TestGetBackupVolumeInfos(t *testing.T) {
require.NoError(t, err)

require.NoError(t, gzw.Close())
harness.objectStore.PutObject(harness.bucket, "backups/test-backup/test-backup-volumeinfos.json.gz", obj)
harness.objectStore.PutObject(harness.bucket, "backups/test-backup/test-backup-volumeinfo.json.gz", obj)
}

result, err := harness.GetBackupVolumeInfos("test-backup")
Expand Down

0 comments on commit 6e641f4

Please sign in to comment.