Merge pull request #8396 from Lyndon-Li/issue-fix-8391

Issue 8391: check ErrCancelled from suffix
vmware-tanzu · Nov 13, 2024 · cb03de4 · cb03de4
2 parents 8e23752 + 7feda11
commit cb03de4
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/changelogs/unreleased/8396-Lyndon-Li b/changelogs/unreleased/8396-Lyndon-Li
@@ -0,0 +1 @@
+Fix issue #8391, check ErrCancelled from suffix of data mover pod's termination message
diff --git a/pkg/datapath/micro_service_watcher.go b/pkg/datapath/micro_service_watcher.go
@@ -20,6 +20,7 @@ import (
 	"context"
 	"encoding/json"
 	"os"
+	"strings"
 	"sync"
 	"time"
 
@@ -321,7 +322,7 @@ func (ms *microServiceBRWatcher) startWatch() {
 		if lastPod.Status.Phase == v1.PodSucceeded {
 			ms.callbacks.OnCompleted(ms.ctx, ms.namespace, ms.taskName, funcGetResultFromMessage(ms.taskType, terminateMessage, ms.log))
 		} else {
-			if terminateMessage == ErrCancelled {
+			if strings.HasSuffix(terminateMessage, ErrCancelled) {
 				ms.callbacks.OnCancelled(ms.ctx, ms.namespace, ms.taskName)
 			} else {
 				ms.callbacks.OnFailed(ms.ctx, ms.namespace, ms.taskName, errors.New(terminateMessage))

diff --git a/pkg/datapath/micro_service_watcher_test.go b/pkg/datapath/micro_service_watcher_test.go
@@ -360,7 +360,7 @@ func TestStartWatch(t *testing.T) {
 					event: &v1.Event{Reason: EventReasonStopped},
 				},
 			},
-			terminationMessage:   ErrCancelled,
+			terminationMessage:   fmt.Sprintf("Failed to init data path service for DataUpload %s: %v", "fake-du-name", errors.New(ErrCancelled)),
 			expectStartEvent:     true,
 			expectTerminateEvent: true,
 			expectCancel:         true,
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix issue #8391, check ErrCancelled from suffix of data mover pod's termination message