Merge pull request #7221 from blackpiglet/schedule_cli_fix

Fix shedule get and describe CLI nil pointer issue
vmware-tanzu · Dec 18, 2023 · ee879fd · ee879fd
2 parents 71b947a + 6222891
commit ee879fd
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/pkg/cmd/cli/schedule/describe.go b/pkg/cmd/cli/schedule/describe.go
@@ -41,9 +41,8 @@ func NewDescribeCommand(f client.Factory, use string) *cobra.Command {
 			crClient, err := f.KubebuilderClient()
 			cmd.CheckError(err)
 
-			var schedules *v1.ScheduleList
+			schedules := new(v1.ScheduleList)
 			if len(args) > 0 {
-				schedules = new(v1.ScheduleList)
 				for _, name := range args {
 					schedule := new(v1.Schedule)
 					err := crClient.Get(context.TODO(), ctrlclient.ObjectKey{Namespace: f.Namespace(), Name: name}, schedule)

diff --git a/pkg/cmd/cli/schedule/get.go b/pkg/cmd/cli/schedule/get.go
@@ -43,9 +43,8 @@ func NewGetCommand(f client.Factory, use string) *cobra.Command {
 			crClient, err := f.KubebuilderClient()
 			cmd.CheckError(err)
 
-			var schedules *api.ScheduleList
+			schedules := new(api.ScheduleList)
 			if len(args) > 0 {
-				schedules = new(api.ScheduleList)
 				for _, name := range args {
 					schedule := new(api.Schedule)
 					err := crClient.Get(context.TODO(), ctrlclient.ObjectKey{Name: name, Namespace: f.Namespace()}, schedule)