Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set "targetNamespace" to namepsace items #7274

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

reasonerjt
Copy link
Contributor

fixes #7263
This commit makes the data structures more consistent, that namespaces, as cluster scoped resource will not have "targetNamespace" in the "restoreableItem" instance.

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (e84a51d) 61.75% compared to head (a5d08ac) 61.76%.

Files Patch % Lines
pkg/restore/restore.go 57.14% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7274   +/-   ##
=======================================
  Coverage   61.75%   61.76%           
=======================================
  Files         262      262           
  Lines       28444    28443    -1     
=======================================
+ Hits        17566    17567    +1     
+ Misses       9646     9645    -1     
+ Partials     1232     1231    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ywk253100
ywk253100 previously approved these changes Jan 4, 2024
fixes vmware-tanzu#7263
This commit makes the data structures more consistent, that namespaces,
as cluster scoped resource will not have "targetNamespace" in the
"restoreableItem" instance.

Signed-off-by: Daniel Jiang <[email protected]>
@reasonerjt reasonerjt merged commit 3401db4 into vmware-tanzu:main Jan 5, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore is stuck when enabling the informer cache
3 participants