Create informer per resources to avoid huge memory consumption #7325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create informer per resources to avoid huge memory consumption Fixes vmware-tanzu#7323 Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
ywk253100
added
the
kind/changelog-not-required
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release-1.13 #7325 +/- ##
================================================
- Coverage 61.76% 61.74% -0.03%
================================================
Files 262 262
Lines 28440 28419 -21
================================================
- Hits 17567 17546 -21
Misses 9642 9642
Partials 1231 1231 ☔ View full report in Codecov by Sentry. |
sseago
approved these changes
Jan 17, 2024
| @@ -1123,6 +1093,7 @@ func (ctx *restoreContext) getResource(groupResource schema.GroupResource, obj * | |||
| ctx.log.WithError(errors.WithStack(fmt.Errorf("expected *unstructured.Unstructured but got %T", u))).Error("unable to understand entry returned from client") | |||
| return nil, fmt.Errorf("expected *unstructured.Unstructured but got %T", u) | |||
| } | |||
| ctx.log.Debugf("get %s, %s/%s from informer cache", groupResource, namespace, name) | |||
shubham-pampattiwar
approved these changes
Jan 17, 2024
|
Thank you @ywk253100 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create informer per resources to avoid huge memory consumption
Fixes #7323
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.