Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-1.15: Reduce minimum go toolchain in go.mod. #8399

Merged
merged 1 commit into from
Dec 4, 2024
Merged

release-1.15: Reduce minimum go toolchain in go.mod. #8399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelogs/unreleased/8399-kaovilai
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Reduce minimum required go toolchain in release-1.15 go.mod
8 changes: 7 additions & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
module github.com/vmware-tanzu/velero

go 1.22.8
// Do not pin patch version here. Leave patch at X.Y.0
// Unset GOTOOLCHAIN to assume GOTOOLCHAIN=local where go cli version in path is used.
// Use env GOTOOLCHAIN=auto to allow go to decide whichever is newer from go.mod or cli in path.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this change affect the release process? E.g., release of 1.15.1.
Do we need to set GOTOOLCHAIN anywhere during the release?

Copy link
Member Author

@kaovilai kaovilai Dec 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope.. no need to set GOTOOLCHAIN. Per prior versions of this PR which verified the golang version used to build, it inherits local go version by default which right now is defined by the Dockerfile.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go version validation removed in
https://github.com/vmware-tanzu/velero/compare/f77f6e33f3d19e2fb41ee22e1440c5e285b3ecaf..9679f607a16d74a6bf96c75d829a65679fbcf1cc
per #8398 (comment)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the standard configuration, the go command uses its own bundled toolchain when that toolchain is at least as new as the go or toolchain lines in the main module or workspace.

// or GOTOOLCHAIN=goX.Y.Z to use a specific toolchain version
// See: https://go.dev/doc/toolchain#select and https://github.com/vmware-tanzu/velero/issues/8397
// To bump minor version, run `go get [email protected] toolchain@none` (ie. `go get [email protected] toolchain@none`)
go 1.22.0

require (
cloud.google.com/go/storage v1.40.0
Expand Down
Loading