Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/archive: Use map of long names avoiding max path limits #8449

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kaovilai
Copy link
Member

@kaovilai kaovilai commented Nov 24, 2024

Signed-off-by: Tiger Kaovilai [email protected]

Thank you for contributing to Velero!

Please add a summary of your change

pkg/archive: Use map of long names avoiding max path limits

Test image: ghcr.io/kaovilai/velero:maxpathlimits-a2699e765 for amd64, arm64

Does your change fix a particular issue?

Fixes #8434

Please indicate you've done the following:

@kaovilai kaovilai marked this pull request as ready for review November 24, 2024 07:38
Copy link

codecov bot commented Nov 24, 2024

Codecov Report

Attention: Patch coverage is 86.04651% with 6 lines in your changes missing coverage. Please review.

Project coverage is 59.00%. Comparing base (9f0026d) to head (a2699e7).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/archive/extractor.go 70.58% 5 Missing ⚠️
pkg/restore/prioritize_group_version.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8449      +/-   ##
==========================================
+ Coverage   58.98%   59.00%   +0.01%     
==========================================
  Files         368      368              
  Lines       39000    39017      +17     
==========================================
+ Hits        23004    23021      +17     
  Misses      14532    14532              
  Partials     1464     1464              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backups stuck Deleting because of "filename too long"
2 participants