Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make single platform built image locally accessible. #8455

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

kaovilai
Copy link
Member

@kaovilai kaovilai commented Nov 25, 2024

Signed-off-by: Tiger Kaovilai [email protected]

Thank you for contributing to Velero!

Please add a summary of your change

Add back output type docker if number of platforms set is one.

BUILDX_OUTPUT_TYPE ?= docker

Does your change fix a particular issue?

Fixes single arch built results when not pushed is inaccessible by docker daemon.
Multiplatform images still cannot be loaded by docker daemon. You must push the image to a registry for access in subsequent steps.

Please indicate you've done the following:

@kaovilai
Copy link
Member Author

/kind changelog-not-required

@github-actions github-actions bot added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Nov 25, 2024
@kaovilai kaovilai closed this Nov 25, 2024
@kaovilai kaovilai reopened this Nov 25, 2024
@github-actions github-actions bot requested a review from Lyndon-Li November 25, 2024 17:36
@kaovilai kaovilai force-pushed the accessible-singleplat-images branch from a34d16e to 369ceb3 Compare November 25, 2024 17:37
@kaovilai kaovilai force-pushed the accessible-singleplat-images branch from 369ceb3 to 483f097 Compare November 25, 2024 17:37
@kaovilai kaovilai changed the title Make single platform built image accessible. Make single platform built image locally accessible. Nov 25, 2024
@Lyndon-Li
Copy link
Contributor

FYI #8459. This PR is merged in order to fix the current problem. We may do further refactors around the local build according to the review result of #8459.

@Lyndon-Li Lyndon-Li merged commit 40a95aa into vmware-tanzu:main Nov 26, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants