Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin kopia to 0.18.2 #8472

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

Lyndon-Li
Copy link
Contributor

Pin kopia to 0.18.2

@github-actions github-actions bot added Dependencies Pull requests that update a dependency file has-unit-tests labels Dec 3, 2024
@Lyndon-Li Lyndon-Li force-pushed the ping-kopia-to-0.18-branch branch from e839e75 to 2309326 Compare December 3, 2024 03:30
@Lyndon-Li Lyndon-Li marked this pull request as ready for review December 3, 2024 03:32
Signed-off-by: Lyndon-Li <[email protected]>
@blackpiglet
Copy link
Contributor

@kaovilai Please notice Golang version in go.mod is bumped to 1.22.7 because Kopia 0.18.2's go module required that version.

@kaovilai
Copy link
Member

kaovilai commented Dec 3, 2024

@blackpiglet that's not ideal but works. 1.22.7 was not very recent.

Copy link
Member

@kaovilai kaovilai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we wait for kopia/kopia#4292 to get resolved?

@Lyndon-Li
Copy link
Contributor Author

Could we wait for kopia/kopia#4292 to get resolved?

We can let go this PR, so that we can test the integration with Kopia 0.18.2 earlier. During a release cycle, we bump up Kopia several times. So once Kopia upstream has a fixing commit, we will cherry-pick it.

go 1.22.0
go 1.22.7

toolchain go1.22.9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually more problematic than the
go 1.22.7 line. It's added by go automatically when go <patch version> is bumped via go get.

We can either delete this manually or follow with go get toolchain@none.

@Lyndon-Li Lyndon-Li merged commit 2e5df85 into vmware-tanzu:main Dec 3, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file has-changelog has-unit-tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants