Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-1.15: CSI: Make cleanup more verbose, and don't fail get on not exist #8480

Draft
wants to merge 1 commit into
base: release-1.15
Choose a base branch
from

Conversation

kaovilai
Copy link
Member

@kaovilai kaovilai commented Dec 3, 2024

Signed-off-by: Tiger Kaovilai [email protected]

Thank you for contributing to Velero!

Please add a summary of your change

Make velero more verbose when deleting snapshots to help diagnose issues when it does happen.

Test image amd/arm64

ghcr.io/kaovilai/velero:verboseCleanup-r1.15-b26183826

Does your change fix a particular issue?

Fixes #8473

Please indicate you've done the following:

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 58.99%. Comparing base (dd1c6a6) to head (b261838).

Files with missing lines Patch % Lines
pkg/util/csi/volume_snapshot.go 57.14% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.15    #8480   +/-   ##
=============================================
  Coverage         58.98%   58.99%           
=============================================
  Files               367      367           
  Lines             38855    38858    +3     
=============================================
+ Hits              22919    22924    +5     
+ Misses            14474    14471    -3     
- Partials           1462     1463    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blackpiglet
Copy link
Contributor

@kaovilai
Hi Tiger, is this PR used for debugging only?
I saw this PR is always in draft state, but also make sure this PR is not merged if it's used for debug purpose.

@kaovilai
Copy link
Member Author

kaovilai commented Dec 9, 2024

For debugging issue yes. If it solves something will open for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants