Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design to add label selector as a criteria for volume policy #8503

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shubham-pampattiwar
Copy link
Collaborator

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Design for #8256

Please indicate you've done the following:

@github-actions github-actions bot added the Area/Design Design Documents label Dec 10, 2024
Signed-off-by: Shubham Pampattiwar <[email protected]>

add changelog file

Signed-off-by: Shubham Pampattiwar <[email protected]>
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.04%. Comparing base (11f100f) to head (a8b3363).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8503      +/-   ##
==========================================
- Coverage   59.04%   59.04%   -0.01%     
==========================================
  Files         369      369              
  Lines       39078    39104      +26     
==========================================
+ Hits        23074    23088      +14     
- Misses      14543    14553      +10     
- Partials     1461     1463       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sseago
Copy link
Collaborator

sseago commented Dec 10, 2024

@shubham-pampattiwar Since users are creating PVCs directly but not generally PVs (and may not have permission to label PVs), should the label selector match PVC labels rather than PV labels?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants