Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs-backup for windows nodes #8518

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Lyndon-Li
Copy link
Contributor

@Lyndon-Li Lyndon-Li commented Dec 17, 2024

Make fs-backup work on linux nodes with the new Velero deployment and disable fs-backup if the source/target pod is running in non-linux node (#8424)

@Lyndon-Li Lyndon-Li force-pushed the fail-fs-backup-on-windows-nodes branch from 54dbb7f to 96cd224 Compare December 17, 2024 06:21
@Lyndon-Li Lyndon-Li force-pushed the fail-fs-backup-on-windows-nodes branch 5 times, most recently from 2e3e3f0 to 33efb69 Compare December 18, 2024 02:18
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 44.82759% with 32 lines in your changes missing coverage. Please review.

Project coverage is 59.16%. Comparing base (ea93c00) to head (3504546).

Files with missing lines Patch % Lines
pkg/cmd/server/server.go 0.00% 12 Missing ⚠️
pkg/util/kube/node.go 62.06% 8 Missing and 3 partials ⚠️
pkg/podvolume/backupper.go 0.00% 4 Missing and 1 partial ⚠️
pkg/nodeagent/node_agent.go 33.33% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8518   +/-   ##
=======================================
  Coverage   59.16%   59.16%           
=======================================
  Files         369      370    +1     
  Lines       39413    39463   +50     
=======================================
+ Hits        23319    23350   +31     
- Misses      14624    14640   +16     
- Partials     1470     1473    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lyndon-Li Lyndon-Li force-pushed the fail-fs-backup-on-windows-nodes branch from 33efb69 to a711b10 Compare December 18, 2024 02:46
@Lyndon-Li Lyndon-Li changed the title Fail fs-backup for windows nodes fs-backup for windows nodes Dec 18, 2024
@Lyndon-Li Lyndon-Li marked this pull request as ready for review December 20, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant