Add maintenance history for backupRepository CRs

[Lyndon-Li]

Fix issue #7810, add maintenance history for backupRepository CRs

[Lyndon-Li]

LastMaintenanceTime should be used to record the completion time of a successful maintenance.
Previously, it is used to record the start time of a successful maintenance, which is not reasonable. E.g., I run a maintenance which takes more than 1 hour; since the default frequency for quick maintenance is 1 hour, the next maintenance will be launched immediately after the first one completes, but actually it is a wasting one as data has just been maintained.
Previously, the description in the CRD is ambiguous, it could mean the completion time or start time.

So in this PR, both the description and the value set to LastMaintenanceTime as changed.

[codecov]

Codecov Report

Attention: Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.

Project coverage is 59.17%. Comparing base (010fd1c) to head (3b2c50b).
Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/controller/backup_repository_controller.go	96.15%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8532      +/-   ##
==========================================
- Coverage   59.18%   59.17%   -0.01%     
==========================================
  Files         369      369              
  Lines       39329    39355      +26     
==========================================
+ Hits        23276    23289      +13     
- Misses      14585    14597      +12     
- Partials     1468     1469       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kaovilai]

Suggested change

	func updateRepoMaintenanceHistory(repo *velerov1api.BackupRepository, result velerov1api.BackupRepositoryMaintenanceResult, startTime time.Time, completionTime time.Time, message string) {
	length := defaultMaintenanceStatusQueueLength
	if len(repo.Status.RecentMaintenanceStatus) < defaultMaintenanceStatusQueueLength {
	length = len(repo.Status.RecentMaintenanceStatus) + 1
	}
	lru := make([]velerov1api.BackupRepositoryMaintenanceStatus, length)
	if len(repo.Status.RecentMaintenanceStatus) >= defaultMaintenanceStatusQueueLength {
	copy(lru[:length-1], repo.Status.RecentMaintenanceStatus[len(repo.Status.RecentMaintenanceStatus)-defaultMaintenanceStatusQueueLength+1:])
	} else {
	copy(lru[:length-1], repo.Status.RecentMaintenanceStatus[:])
	}
	lru[length-1] = velerov1api.BackupRepositoryMaintenanceStatus{
	Result: result,
	StartTimestamp: &metav1.Time{Time: startTime},
	CompleteTimestamp: &metav1.Time{Time: completionTime},
	Message: message,
	}
	repo.Status.RecentMaintenanceStatus = lru
	}
	func addRepoMaintenanceHistory(repo *velerov1api.BackupRepository, result velerov1api.BackupRepositoryMaintenanceResult, startTime time.Time, completionTime time.Time, message string) {
	length := defaultMaintenanceStatusQueueLength
	resultStatus := velerov1api.BackupRepositoryMaintenanceStatus{
	Result: result,
	StartTimestamp: &metav1.Time{Time: startTime},
	CompleteTimestamp: &metav1.Time{Time: completionTime},
	Message: message,
	}
	startingPos := 0
	if len(repo.Status.RecentMaintenanceStatus) >= length {
	// discard old element(s)
	startingPos = len(repo.Status.RecentMaintenanceStatus) - length + 1
	}
	repo.Status.RecentMaintenanceStatus = append(repo.Status.RecentMaintenanceStatus[startingPos:], resultStatus)
	}

Thoughts?