Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide restic deprecation warning for install with crd-only #8538

Conversation

Lyndon-Li
Copy link
Contributor

@Lyndon-Li Lyndon-Li commented Dec 20, 2024

Fix issue #8539, validate uploader types when o.CRDsOnly is set to false only since CRD installation doesn't rely on uploader types

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 59.18%. Comparing base (ea93c00) to head (be97a5c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/cmd/cli/install/install.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8538      +/-   ##
==========================================
+ Coverage   59.16%   59.18%   +0.02%     
==========================================
  Files         369      369              
  Lines       39413    39413              
==========================================
+ Hits        23319    23327       +8     
+ Misses      14624    14617       -7     
+ Partials     1470     1469       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lyndon-Li Lyndon-Li force-pushed the hide-restic-deprecation-warning-for-install-crd-only branch from 3850a07 to be97a5c Compare December 20, 2024 06:48
@Lyndon-Li Lyndon-Li marked this pull request as ready for review December 20, 2024 06:48
@Lyndon-Li Lyndon-Li merged commit e85f18d into vmware-tanzu:main Dec 20, 2024
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants