Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recall repo maintenance history on restart #8580

Merged

Conversation

Lyndon-Li
Copy link
Contributor

@Lyndon-Li Lyndon-Li commented Jan 6, 2025

Fix issue #7753, recall repo maintenance history on Velero server restart.
Refactor the code to manipulate maintenance job from backupRepository controller and use repo Manager purely as a bridge of repo operations.

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 68.83910% with 153 lines in your changes missing coverage. Please review.

Project coverage is 59.35%. Comparing base (3eaa739) to head (91fcb65).
Report is 45 commits behind head on main.

Files with missing lines Patch % Lines
pkg/repository/maintenance/maintenance.go 70.77% 90 Missing and 12 partials ⚠️
pkg/cmd/cli/repomantenance/maintenance.go 0.00% 31 Missing ⚠️
pkg/controller/backup_repository_controller.go 90.42% 9 Missing ⚠️
pkg/cmd/server/server.go 0.00% 6 Missing ⚠️
pkg/repository/manager/manager.go 54.54% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8580      +/-   ##
==========================================
+ Coverage   59.18%   59.35%   +0.16%     
==========================================
  Files         370      370              
  Lines       39595    39932     +337     
==========================================
+ Hits        23434    23700     +266     
- Misses      14679    14737      +58     
- Partials     1482     1495      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lyndon-Li Lyndon-Li force-pushed the recall-repo-maintenance-history-on-restart branch 2 times, most recently from de12053 to 4aa06f7 Compare January 6, 2025 09:01
@Lyndon-Li Lyndon-Li force-pushed the recall-repo-maintenance-history-on-restart branch from 4aa06f7 to 6b73a25 Compare January 6, 2025 09:11
@Lyndon-Li Lyndon-Li force-pushed the recall-repo-maintenance-history-on-restart branch 4 times, most recently from f9c91e8 to f041572 Compare January 7, 2025 03:35
@Lyndon-Li Lyndon-Li force-pushed the recall-repo-maintenance-history-on-restart branch from f041572 to 4ce7361 Compare January 7, 2025 04:58
@github-actions github-actions bot added the Dependencies Pull requests that update a dependency file label Jan 7, 2025
@Lyndon-Li Lyndon-Li force-pushed the recall-repo-maintenance-history-on-restart branch from cb26980 to b19dd9a Compare January 7, 2025 06:55
@Lyndon-Li Lyndon-Li marked this pull request as ready for review January 7, 2025 06:55
@Lyndon-Li Lyndon-Li force-pushed the recall-repo-maintenance-history-on-restart branch from b19dd9a to c76facf Compare January 7, 2025 07:01
go.mod Show resolved Hide resolved
pkg/cmd/cli/repomantenance/maintenance.go Outdated Show resolved Hide resolved
pkg/cmd/cli/repomantenance/maintenance.go Outdated Show resolved Hide resolved
@Lyndon-Li Lyndon-Li force-pushed the recall-repo-maintenance-history-on-restart branch 2 times, most recently from 7077ebe to 19b1423 Compare January 7, 2025 08:07
@Lyndon-Li Lyndon-Li requested a review from kaovilai January 7, 2025 08:07
@Lyndon-Li Lyndon-Li force-pushed the recall-repo-maintenance-history-on-restart branch from 19b1423 to fc96836 Compare January 13, 2025 02:57
@Lyndon-Li Lyndon-Li requested a review from kaovilai January 13, 2025 02:57
kaovilai
kaovilai previously approved these changes Jan 13, 2025
pkg/repository/maintenance/maintenance.go Outdated Show resolved Hide resolved
pkg/repository/maintenance/maintenance.go Outdated Show resolved Hide resolved
pkg/controller/backup_repository_controller.go Outdated Show resolved Hide resolved
pkg/repository/maintenance/maintenance.go Outdated Show resolved Hide resolved
@Lyndon-Li Lyndon-Li force-pushed the recall-repo-maintenance-history-on-restart branch from 6be1a91 to 3900f2f Compare January 15, 2025 07:05
@Lyndon-Li Lyndon-Li force-pushed the recall-repo-maintenance-history-on-restart branch from 6f33dc6 to 0045e94 Compare January 15, 2025 09:35
Copy link
Contributor

@reasonerjt reasonerjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@Lyndon-Li Lyndon-Li merged commit 5b1738a into vmware-tanzu:main Jan 17, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file has-changelog has-unit-tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants