Configurable Kopia Maintenance Interval

[kaovilai]

Signed-off-by: Tiger Kaovilai [email protected]

Thank you for contributing to Velero!

Please add a summary of your change

Configurable Kopia Maintenance Interval. repo-maintenance-job-configmap adds an option for fullMaintenanceInterval where fastGC (12 hours), and eagerGC (6 hours).
This configmap is loaded in assembleRepoParam that returns RepoParam which now contains the maintenance interval referenced by several repository functions.
The manager functions then call provider functions which read repoParam.FullMaintenanceInterval and add it to repoOption.
Repooption is then passed to repoService, in this case kopiaRepoService.Init
kopiaRepoService.Init calls writeInitParameters which finally set kopia p.FullCycle.Interval

Doc previews

https://velero-git-configkopiamaintinterval-kaovilais-projects.vercel.app/docs/main/repository-maintenance#full-maintenance-interval-customization
https://velero-git-configkopiamaintinterval-kaovilais-projects.vercel.app/docs/main/backup-repository-configuration/#full-maintenance-interval-customization

Does your change fix a particular issue?

Fixes #8364

Please indicate you've done the following:

• Accepted the DCO. Commits without the DCO will delay acceptance.
• Created a changelog file (make new-changelog) or comment /kind changelog-not-required on this PR.
• Updated the corresponding documentation in site/content/docs/main.

[codecov]

Codecov Report

Attention: Patch coverage is 84.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 59.50%. Comparing base (0f81772) to head (178b6e3).
Report is 14 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/repository/udmrepo/kopialib/lib_repo.go	73.33%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8581      +/-   ##
==========================================
+ Coverage   59.48%   59.50%   +0.01%     
==========================================
  Files         371      371              
  Lines       40191    40213      +22     
==========================================
+ Hits        23909    23929      +20     
- Misses      14789    14791       +2     
  Partials     1493     1493              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kaovilai]

Currently double checking the flow of backup-repository-configmap from specifying a configmap to reading to storing into a repoOption.StorageOptions[key]

velero/pkg/controller/backup_repository_controller.go

Lines 404 to 405 in b4247c9

	func getBackupRepositoryConfig(ctx context.Context, ctrlClient client.Client, configName, namespace, repoName, repoType string, log logrus.FieldLogger) (map[string]string, error) {
	if configName == "" {

is called [here](

velero/pkg/controller/backup_repository_controller.go

Line 249 in 92390e9

config, err := getBackupRepositoryConfig(ctx, r, r.backupRepoConfig, r.namespace, req.Name, req.Spec.RepositoryType, log)

which defines config := map[string]string with all the values set by user.
This map of string is then set to backupRepository.spec.RepositoryConfig and patched to cluster CR in following

velero/pkg/controller/backup_repository_controller.go

Line 233 in 92390e9

func (r *BackupRepoReconciler) initializeRepo(ctx context.Context, req *velerov1api.BackupRepository, log logrus.FieldLogger) error {

This function is only called when backupRepo is in newly created as part of a backuprepo Reconcile()

This is used by

velero/pkg/repository/provider/unified_repo.go

Line 394 in 69b456a

func (urp *unifiedRepoProvider) GetStoreOptions(param interface{}) (map[string]string, error) {

via

velero/pkg/repository/provider/unified_repo.go

Line 400 in 69b456a

storeVar, err := funcTable.getStorageVariables(repoParam.BackupLocation, urp.repoBackend, repoParam.BackupRepo.Spec.VolumeNamespace, repoParam.BackupRepo.Spec.RepositoryConfig)

However, getStorageVariables() do not pass all the options from backupRepoConfig back.

velero/pkg/repository/provider/unified_repo.go

Lines 571 to 575 in b4247c9

	if backupRepoConfig != nil {
	if v, found := backupRepoConfig[udmrepo.StoreOptionCacheLimit]; found {
	result[udmrepo.StoreOptionCacheLimit] = v
	}
	}

So either make getStorageVariables() pass everything, or make it add the maintenance interval to one of the things it adds.

[Lyndon-Li]

@kaovilai
There are some UT failures, please help to fix them.

[Lyndon-Li]

@kaovilai
I think we can add some UT for the new logics added in this PR.