-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repo maintenance for windows #8626
Repo maintenance for windows #8626
Conversation
bdf495f
to
fe408e5
Compare
fe408e5
to
09fcbc8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8626 +/- ##
==========================================
+ Coverage 59.33% 59.39% +0.06%
==========================================
Files 370 370
Lines 39932 39952 +20
==========================================
+ Hits 23692 23730 +38
+ Misses 14744 14731 -13
+ Partials 1496 1491 -5 ☔ View full report in Codecov by Sentry. |
f7a04c9
to
c852a7f
Compare
Signed-off-by: Lyndon-Li <[email protected]>
c852a7f
to
0a4b05c
Compare
return "", nil | ||
} | ||
|
||
idx := strings.Index(terminated.Message, TerminationLogIndicator) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need the indicator? Why cannot we return the termination message directly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The termination message is written to stdout together with logrus logs. So we use this indicator to identify it among other logs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the behavior of TerminationMessageFallbackToLogsOnError
, the last 2048 bytes of stdout is retrieved as the termination message whatever are there in the bytes.
Fix issue #8419, support repo maintenance job to run on Windows nodes:
TerminationMessagePolicy
toTerminationMessageFallbackToLogsOnError
, as kubelet has a bug to supportTerminationMessageReadFile
on Windows