-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add labels as a criteria for volume policy #8713
Add labels as a criteria for volume policy #8713
Conversation
06b2e5d
to
62a0d5e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8713 +/- ##
==========================================
+ Coverage 59.51% 59.53% +0.02%
==========================================
Files 371 371
Lines 40179 40191 +12
==========================================
+ Hits 23911 23927 +16
+ Misses 14775 14767 -8
- Partials 1493 1497 +4 ☔ View full report in Codecov by Sentry. |
62a0d5e
to
0060579
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. This matches the current design.
c217ad6
0060579
to
c217ad6
Compare
c217ad6
to
687342d
Compare
487f9fc
687342d
to
487f9fc
Compare
Signed-off-by: Shubham Pampattiwar <[email protected]> add changelog file Signed-off-by: Shubham Pampattiwar <[email protected]> handle err Signed-off-by: Shubham Pampattiwar <[email protected]> use labels selector.matches Signed-off-by: Shubham Pampattiwar <[email protected]> make update Signed-off-by: Shubham Pampattiwar <[email protected]> remove fetching pvc from volume policy filtering Signed-off-by: Shubham Pampattiwar <[email protected]> add more ut coverage Signed-off-by: Shubham Pampattiwar <[email protected]>
487f9fc
to
e6493fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is going in the right direction, but a couple of suggestions in my review comments.
1801a42
to
085e5f7
Compare
@shubham-pampattiwar Some minor changes suggested, please have another look. Thanks! |
085e5f7
to
dd5249c
Compare
Signed-off-by: Shubham Pampattiwar <[email protected]> use VolumeFilterData struct in GetMatchAction func Signed-off-by: Shubham Pampattiwar <[email protected]> update parsePVC func and add more ut Signed-off-by: Shubham Pampattiwar <[email protected]> lint fix Signed-off-by: Shubham Pampattiwar <[email protected]>
dd5249c
to
f756a6d
Compare
Thank you for contributing to Velero!
Please add a summary of your change
Implementation for design #8503
Does your change fix a particular issue?
Fixes #8256
Please indicate you've done the following:
make new-changelog
) or comment/kind changelog-not-required
on this PR.site/content/docs/main
.