Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue 8649: host_pods should not be mandatory to node-agent #8774

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mpryc
Copy link
Contributor

@mpryc mpryc commented Mar 10, 2025

Fixes #8649. The host_pods path should not be mandatory for node-agent.

This update enables the node-agent to start even if the /host_pods path does not exist. If the path is present, the existing logic remains unchanged, ensuring it is readable.

This PR does not address mounting (or omitting) the /host_pods directory.

Additionally, this change specifically resolves #8649 and not #8185, which requires further design work and will be handled in a separate PR.

@kaovilai
Copy link
Member

Don't be alarmed about e2e tests.. unrelated to PR #8766

Copy link

codecov bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 59.53%. Comparing base (1516e72) to head (3262b86).

Files with missing lines Patch % Lines
pkg/cmd/cli/nodeagent/server.go 28.57% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8774      +/-   ##
==========================================
- Coverage   59.53%   59.53%   -0.01%     
==========================================
  Files         371      371              
  Lines       40196    40200       +4     
==========================================
  Hits        23932    23932              
- Misses      14767    14771       +4     
  Partials     1497     1497              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

host_pods should not be mandatory to node-agent after 1.15
2 participants