Merge pull request #768 from abaruni/topic/badnan/quota-webhook-cel-fix

🐛 Correctly handle optional, nillable path in CEL expression
vmware-tanzu · Oct 24, 2024 · 7941a83 · 7941a83
2 parents 38b38ba + a8ec872
commit 7941a83
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/config/webhook/storage_quota_webhook_configuration.yaml b/config/webhook/storage_quota_webhook_configuration.yaml
@@ -48,5 +48,8 @@ webhooks:
     - virtualmachines
   sideEffects: None
   matchConditions:
-  - expression: oldObject.spec.advanced.bootDiskCapacity != object.spec.advanced.bootDiskCapacity
+  - expression: has(object.spec.advanced) && has(object.spec.advanced.bootDiskCapacity)
+      && ((!has(oldObject.spec.advanced) || !has(oldObject.spec.advanced.bootDiskCapacity))
+      || (has(oldObject.spec.advanced) && has(oldObject.spec.advanced.bootDiskCapacity)
+      && object.spec.advanced.bootDiskCapacity != oldObject.spec.advanced.bootDiskCapacity))
     name: boot-disk-change