🌱 Replace ValidatingWebhookConfiguration controller with watch in StoragePolicyQuota controller #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abaruni
force-pushed
the
topic/badnan/validatingwebhookconfiguration-watch
branch
from
66ffd9a to
ee8d0e0
Compare
…gepolicyquota controller
abaruni
force-pushed
the
topic/badnan/validatingwebhookconfiguration-watch
branch
from
ee8d0e0 to
6305b07
Compare
Minimum allowed line rate is |
bryanv
approved these changes
Dec 13, 2024
| for i := range spu.OwnerReferences { | ||
| owner := &spu.OwnerReferences[i] | ||
| if owner.Kind == StoragePolicyQuotaKind { | ||
| owningObj = owner |
| }) | ||
| }) | ||
|
|
||
| Context("", func() { |
There was a problem hiding this comment.
Context("StoragePolicyUsage") or something?
sreyasn
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
This change removes the existing
ValidatingWebhookConfigurationcontroller and replaces it with watch configured on theStoragePolicyQuotacontroller which watches for changes toValidatingWebhookConfigurations.The functionality remains the same--any updates to the Webhook Server CA bundle will cause reconciliation to occur and update the CA bundle for any VM
StoragePolicyUsage.Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Are there any special notes for your reviewer:
Please add a release note if necessary: