Adds installCrd flag to helm chart values.

This solves the user experience problem of reading the documentation about the CRD, running helm install, and not being able to see the CRD in the api-resources. Previously the CRD was only installed if the datasource was crd, or the crdMigrationMode was turned on, which was a confusing experience for me as a newcomer. Authored-by: Adam Berlin <[email protected]> Signed-off-by: Adam Berlin <[email protected]>
vmware · Oct 21, 2022 · ce88625 · ce88625
1 parent bfe8a2c
commit ce88625
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/charts/log-router/crds/crd.yaml → charts/log-router/templates/crd.yaml b/charts/log-router/crds/crd.yaml → charts/log-router/templates/crd.yaml
@@ -1,3 +1,12 @@
+{{ if .Values.installCrd }}
+{{- /* if we need the CRD, install it */ -}}
+
+{{/*
+  this CRD needs to live in the template directory because CRDs within the
+  chart crds/ directory are not processed as templates
+*/}}
+
+#
 # log-router CRD resource:
 apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
@@ -26,3 +35,4 @@ spec:
         type: object
     served: true
     storage: true
+{{ end }}
diff --git a/charts/log-router/values.yaml b/charts/log-router/values.yaml
@@ -21,6 +21,9 @@ datasource: default
 # together with the specified legacy datasource to facilitate the migration process to CRDs.
 crdMigrationMode: false
 
+# default to installing the CRD along with the helm chart
+installCrd: true
+
 defaultConfigmap: "fluentd-config"
 
 image: