Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for optional ethernet mac address in hardware config #74

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

ComrexSteve
Copy link

We had a need to generate OVA/OVF with the Ethernet MAC address as a parameter. This adds support for that with an optional "address" specified in the ethernet hardware config yaml.

    ethernet1:
        type: ethernet
        subtype: VmxNet3
        network: vm_network1
        address: !param mac_primary

@oliverkurth
Copy link
Contributor

This looks good to me, thank you! Please fix the issue with the DCO, and I will merge this.

Optionally, you can create a test for this too.

@oliverkurth
Copy link
Contributor

I almost forgot this - thank you! Merging.

@oliverkurth oliverkurth merged commit aa8129b into vmware:master Feb 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants