Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify documentation on sequence number in rules #1007

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Clarify documentation on sequence number in rules #1007

merged 1 commit into from
Oct 25, 2023

Conversation

annakhm
Copy link
Collaborator

@annakhm annakhm commented Oct 20, 2023

No description provided.

@@ -85,7 +85,7 @@ In addition to arguments listed above, the following attributes are exported:
* `rule`:
* `revision` - Indicates current revision number of the object as seen by NSX-T API server. This attribute can be useful for debugging.
* `path` - The NSX policy path for this rule.
* `sequence_number` - Sequence number of the this rule, is defined by order of rules in the list.
* `sequence_number` - Sequence number for this rule, as defined by order of rules in the list.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why removed "as defined by order of rules in the list" on lines 172, 190 but left here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here sequence_number is read only attribute, so it is only dictated by rule order. In gateway policy and security policy you can specify sequence_number

@annakhm annakhm requested a review from ksamoray October 24, 2023 20:44
Copy link
Collaborator

@GraysonWu GraysonWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annakhm annakhm merged commit 3cd625e into master Oct 25, 2023
2 checks passed
@annakhm annakhm deleted the fix-docs branch February 5, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants