chore: remove use of io/ioutil
#1421
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code LGTM - would wait until we reestablish our acceptance tests CI env to validate this change |
|
@vmware/terraform-provider-nsxt-maintainers: reminder. |
Removes the use of `io/ioutil`. As of Go 1.16, the same functionality is now provided by package `io` or package `os`, and those implementations are preferred in new code. Signed-off-by: Ryan Johnson <[email protected]>
tenthirtyam
force-pushed
the
chore/remove-io-ioutil
branch
from
9120fe1 to
e65b291
Compare
salv-orlando
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
LGTM.
This change is safe per https://pkg.go.dev/io/ioutil#ReadAll and should not need a full validation,
ksamoray
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Pull Request
Removes the use of
io/ioutil.As of Go 1.16, the same functionality is now provided by package
ioor packageos, and those implementations are preferred in new code.Type of Pull Request
Please describe:
Related to Existing Issues
Test and Documentation Coverage
For bug fixes or features:
Breaking Changes?