Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add issue templates #1430

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

tenthirtyam
Copy link
Collaborator

Summary of Pull Request

Adds issue templates in the form format for:

  • Bugs
  • Documentation
  • Enhancements

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style/formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Related to Existing Issues

Test and Documentation Coverage

For bug fixes or features:

  • Tests have been completed.
  • Documentation has been added/updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@tenthirtyam tenthirtyam added the chore Chore label Oct 14, 2024
@tenthirtyam tenthirtyam requested a review from annakhm October 14, 2024 13:51
@tenthirtyam tenthirtyam self-assigned this Oct 14, 2024
@tenthirtyam tenthirtyam force-pushed the chore/add-issue-templates branch from c5c8ec8 to c518311 Compare October 14, 2024 14:01
@tenthirtyam tenthirtyam added needs-review Needs Review size/s Relative Sizing: small labels Oct 14, 2024
@tenthirtyam tenthirtyam requested review from a team and removed request for annakhm October 28, 2024 21:32
@tenthirtyam
Copy link
Collaborator Author

@ksamoray @annakhm @salv-orlando - Could you review this item for adding form-based issue templates?

@tenthirtyam
Copy link
Collaborator Author

@vmware/terraform-provider-nsxt-maintainers: reminder.

Adds issue templates in the form format for bugs, documentation, and enhancements.

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam force-pushed the chore/add-issue-templates branch from c518311 to 4ae34db Compare January 8, 2025 14:44
Copy link
Member

@salv-orlando salv-orlando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@annakhm can you please take a look as well?

description: |
Please provide a link to a [GitHub Gist](https://gist.github.com/) containing the complete debug output.
placeholder: |
Link to a GitHub Gist. Please do not paste the debug output in the issue.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be fair, we're actually fine if users post the output directly on the issue. In many cases they just paste the relevant snippet.

Can we rephrase this to something like:
Link to a GitHub Gist and/or paste a snippet from the debug log which will be informative enough to allow us to root cause the issue

description: |
If Terraform produced a panic, please provide a link to a [GitHub Gist](https://gist.github.com/) containing the output of the `crash.log`
placeholder: |
Link to a GitHub Gist. Please do not paste the panic output in the issue.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above. Often the panic is easily identified by a small stack trace.

@@ -0,0 +1 @@
blank_issues_enabled: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not do this? Mostly for self-filed issues, we might not want to go through the whole template.

options:
- label: I have read and agree to the [Code of Conduct](https://github.com/vmware/terraform-provider-nsxt/blob/main/CODE_OF_CONDUCT.md).
required: true
- label: Vote on this issue by adding a 👍 [reaction](https://blog.github.com/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/) to the original issue initial description to help the maintainers prioritize.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have lines 21-26 in a markdown section as for the documentation template?

options:
- label: I have read and agree to the project's Code of Conduct.
required: true
- label: Vote on this issue by adding a 👍 [reaction](https://blog.github.com/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/) to the original issue initial description to help the maintainers prioritize.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as for bug.YML

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore needs-review Needs Review size/s Relative Sizing: small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants