Fix login credential type identifier parsing #989
Conversation
| @@ -449,7 +449,7 @@ func setCredentialValuesInSchema(d *schema.ResourceData, credential *data.Struct | |||
| return errors.New("no valid credential found") | |||
| } | |||
|
|
|||
| d.Set("credential", elem) | |||
| d.Set("credential", []interface{}{elem}) | |||
There was a problem hiding this comment.
was this wrong before and we did not realize only because elem was an empty map?
There was a problem hiding this comment.
Indeed. And the list was empty as the constants which were used in the switch case were wrong as well. So values were taken from the state.
| @@ -435,7 +435,7 @@ func setCredentialValuesInSchema(d *schema.ResourceData, credential *data.Struct | |||
| elem["thumbprint"] = credEntry.Thumbprint | |||
| elem["password"] = credEntry.Password | |||
There was a problem hiding this comment.
Would we see non-empty diff here since sensitive data is not sent back by NSX?
There was a problem hiding this comment.
Yep - in transport node the polymorphic objects are recreated with make(map[]interface{}), while here the same map is being populated with the GET values. So passwords are retained from the state.
I'm implementing a similar mechanism for transport node.
There was a problem hiding this comment.
Sorry - I'm still missing something.. I see elem is initialized as an empty map, and then populated with GET values. I'm missing the part where passwords are coming from the state..
There was a problem hiding this comment.
You're right - the code actually works since I don't assign these elem structs into "username_password_login" etc schema as I should.
I'll revise this farther.
ksamoray
force-pushed
the
compute_mgr_creds
branch
5 times, most recently
from
a447291 to
df08b5f
Compare
NSX does not return sensitive data (e.g passwords) on GET operation, and therefore TF detects a diff. But as the schema.Resource object contains the credentials from the state, we can keep these intact and then the value will remain as is and stored again in the state. Signed-off-by: Kobi Samoray <[email protected]>
Values used for type identifier parsing were incorrect Signed-off-by: Kobi Samoray <[email protected]>
ksamoray
force-pushed
the
compute_mgr_creds
branch
from
df08b5f to
f1e6000
Compare
Values used for type identifier parsing were incorrect