Avoid applying lisence on every init #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we support a case where a user adds a license via UI? I think that in this case, this license will be removed. |
Good point Kobi. I was contemplating doing nothing if license is not specified. This will cause an issue when removing licenses that were specified earlier.. |
Previous code assumed GetChange SDK routine works for provider attributes, which it doesn't (provider attributes are not stored in state). In order to avoid reapplying licenses on every init, this change pulls license keys from backend and only applies the diff. The provider will never remove licenses, this is to avoid scenario when provider removes license that was manually applied on NSX. Signed-off-by: Anna Khmelnitsky <[email protected]>
annakhm
force-pushed
the
license-diff-fix
branch
from
3011acf to
bb50a2c
Compare
ksamoray
approved these changes
Oct 19, 2023
|
/test-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous code assumed GetChange SDK routine works for provider attributes, which it doesn't (provider attributes are not stored in state).
In order to avoid reapplying licenses on every init, this change pulls license keys from backend and only applies/removes the diff.