Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix linter issues #481

Merged
merged 1 commit into from
Dec 17, 2024
Merged

chore: fix linter issues #481

merged 1 commit into from
Dec 17, 2024

Conversation

vivgoyal
Copy link
Contributor

@vivgoyal vivgoyal commented Dec 17, 2024 •
edited by tenthirtyam
Loading

Summary

Type

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style/formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Test and Documentation

  • Tests have been completed.
  • Documentation has been added or updated.

Issue References

Additional Information

@vmwclabot vmwclabot added the dco-required DCO Required label Dec 17, 2024
@github-actions github-actions bot added provider Provider needs-review Needs Review labels Dec 17, 2024
@vmwclabot vmwclabot removed the dco-required DCO Required label Dec 17, 2024
@vivgoyal vivgoyal force-pushed the fix-linters branch 3 times, most recently from 4af28de to 9dbfae2 Compare December 17, 2024 20:06
@vivgoyal
Fix linter issues
1f051c0 
Signed-off-by: Vivek Goyal <[email protected]>
@vivgoyal vivgoyal changed the title Draft: Fix linter issues Fix linter issues Dec 17, 2024
@vivgoyal vivgoyal marked this pull request as ready for review December 17, 2024 20:13
@vivgoyal vivgoyal self-assigned this Dec 17, 2024
@vivgoyal vivgoyal added this to the .next milestone Dec 17, 2024
@vivgoyal vivgoyal linked an issue Dec 17, 2024 that may be closed by this pull request
Address findings from the linters configured in golangci-lint. #457
Closed
4 tasks
@vivgoyal vivgoyal requested a review from tenthirtyam December 17, 2024 20:15
@vmware vmware deleted a comment from vmwclabot Dec 17, 2024
@tenthirtyam tenthirtyam changed the title Fix linter issues chore: fix linter issues Dec 17, 2024
tenthirtyam
tenthirtyam approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@tenthirtyam tenthirtyam added the chore Chore label Dec 17, 2024
@vivgoyal vivgoyal merged commit 5f9eb82 into main Dec 17, 2024
11 checks passed
@vivgoyal vivgoyal deleted the fix-linters branch December 17, 2024 21:12
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tenthirtyam tenthirtyam tenthirtyam approved these changes

Assignees

@vivgoyal vivgoyal

Labels
chore Chore needs-review Needs Review provider Provider
Projects
None yet
Milestone
v1.4.8
Development

Successfully merging this pull request may close these issues.

Address findings from the linters configured in golangci-lint.
3 participants
@vivgoyal @tenthirtyam @vmwclabot