fix: change terraform file style from imperative to declarative

[stevewallone]

Summary

The terraform files use an imperative style, i.e. create_tkg_cluster. The convention is to use a declarative style that doesn't imply an actions, i.e. tkg_cluster.

Type

• This is a bug fix.
• This is an enhancement or feature.
• This is a code style/formatting update.
• This is a documentation update.
• This is a refactoring update.
• This is a chore update
• This is something else.
  Please describe:

Breaking Changes?

• Yes, there are breaking changes.
• No, there are no breaking changes.

Test and Documentation

• Tests have been completed.
• Documentation has been added or updated.

Issue References

Resolves #482

Additional Information

[vmwclabot]

@stevewallone, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 5ab5820 must be signed by [email protected]

[vmwclabot]

@stevewallone, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 5ab5820 must be signed by [email protected]
• Commit b87d80a must be signed by [email protected]
• Commit e4908dd must be signed by [email protected]

[vmwclabot]

@stevewallone, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 3e06f8a must be signed by [email protected]

[stevewallone]

I believe the commit message is good to go. Please let me know if there's anything else I need to do.

[tenthirtyam]

The sign off needs to be on its own line.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.96%. Comparing base (3578fd2) to head (3e06f8a).
Report is 74 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (3578fd2) and HEAD (3e06f8a). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (3578fd2)	HEAD (3e06f8a)
	2	1

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #487      +/-   ##
==========================================
- Coverage   25.23%   19.96%   -5.27%     
==========================================
  Files         195      264      +69     
  Lines       16908    23632    +6724     
==========================================
+ Hits         4267     4719     +452     
- Misses      12423    18699    +6276     
+ Partials      218      214       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[vmwclabot]

@stevewallone, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 89ba6eb must be signed by [email protected]

[vmwclabot]

@stevewallone, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 85461be must be signed by [email protected]

[vmwclabot]

@stevewallone, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 6ad66d9 must be signed by [email protected]

[tenthirtyam]

The sign off needs to be on its own line.

@stevewallone - I've resolved the sign-off for you in fa3e22a.

[tenthirtyam]

All instances of the changes to create_duration to duration for the hashicorp/time provider need to be reverted.

The argument is create_duration.

[vmwclabot]

@stevewallone, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 3e06f8a must be signed by [email protected]
• Commit e1ca277 must be signed by [email protected]

[stevewallone]

Closing PR. Will create another one that is clean.