Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use bincode serialize for better compatibility #520

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

vnghia
Copy link
Owner

@vnghia vnghia commented Nov 27, 2024

No description provided.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 45.56962% with 43 lines in your changes missing coverage. Please review.

Project coverage is 81.76%. Comparing base (f74cb44) to head (c7a616b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
nghe-api/src/common/mod.rs 0.00% 4 Missing and 1 partial ⚠️
nghe-backend/src/auth/mod.rs 50.00% 2 Missing and 1 partial ⚠️
nghe-api/src/auth/mod.rs 0.00% 1 Missing and 1 partial ⚠️
nghe-api/src/browsing/get_artists.rs 0.00% 2 Missing ⚠️
nghe-api/src/browsing/get_music_folders.rs 0.00% 2 Missing ⚠️
nghe-api/src/id3/artist/mod.rs 0.00% 2 Missing ⚠️
nghe-api/src/id3/genre/mod.rs 0.00% 2 Missing ⚠️
nghe-proc-macro/src/api.rs 92.85% 0 Missing and 2 partials ⚠️
nghe-api/src/browsing/get_album_info2.rs 0.00% 1 Missing ⚠️
nghe-api/src/browsing/get_artist_info2.rs 0.00% 1 Missing ⚠️
... and 21 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #520      +/-   ##
==========================================
+ Coverage   81.57%   81.76%   +0.19%     
==========================================
  Files         173      173              
  Lines        5004     5013       +9     
  Branches     5004     5013       +9     
==========================================
+ Hits         4082     4099      +17     
+ Misses        595      594       -1     
+ Partials      327      320       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vnghia vnghia merged commit 19a6db9 into main Nov 27, 2024
13 of 15 checks passed
@vnghia vnghia deleted the new-binary-format branch December 11, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant