Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Validators #80

Merged
merged 8 commits into from
Aug 1, 2024
Merged

Improve Validators #80

merged 8 commits into from
Aug 1, 2024

Conversation

selankon
Copy link
Collaborator

@selankon selankon commented Jul 29, 2024

Fix #76
Depends on https://github.com/vocdoni/vocdoni-sdk/pull/402/files

  • Implement validators detail page
  • Fix block link to validator

It extracts a new component called IconLink used to create links with icon. The idea is to implement some kind of links on different places with a leading icon like:

image

This is related to #79 which will need this component

@selankon selankon force-pushed the f/implement-validators-info branch from 89dd4f5 to f655b70 Compare July 29, 2024 09:57
@selankon selankon marked this pull request as ready for review July 29, 2024 10:03
Copy link

github-actions bot commented Jul 29, 2024

@github-actions github-actions bot temporarily deployed to pull request July 29, 2024 10:05 Inactive
Copy link

github-actions bot commented Jul 29, 2024

@github-actions github-actions bot temporarily deployed to pull request July 29, 2024 10:05 Inactive
src/components/Validators/ValidatorCard.tsx Outdated Show resolved Hide resolved
src/components/Validators/Detail.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request July 31, 2024 06:30 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 31, 2024 06:30 Inactive
@selankon selankon force-pushed the f/implement-validators-info branch from 4e26d9c to 066b12a Compare July 31, 2024 06:31
@github-actions github-actions bot temporarily deployed to pull request July 31, 2024 06:31 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 31, 2024 06:31 Inactive
@selankon selankon force-pushed the f/implement-validators-info branch from 066b12a to efcf103 Compare July 31, 2024 06:32
@github-actions github-actions bot temporarily deployed to pull request July 31, 2024 06:33 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 31, 2024 06:33 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 31, 2024 06:35 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 31, 2024 06:35 Inactive
@selankon
Copy link
Collaborator Author

@elboletaire I added a link to the validator account address, I don't know if it has sense to have this info available...

92589d2

@github-actions github-actions bot temporarily deployed to pull request July 31, 2024 06:38 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 31, 2024 06:38 Inactive
@elboletaire
Copy link
Member

elboletaire commented Jul 31, 2024

@elboletaire I added a link to the validator account address, I don't know if it has sense to have this info available...

92589d2

I feel like there are too much copy options in the validators list now. I'd leave them without the copies I think, since we now have a view and you can see all the details there, it's better to keep the copy buttons there only.

Well I see it improves with names defined, but it still feels weird when they aren't:
imatge
imatge

@github-actions github-actions bot temporarily deployed to pull request August 1, 2024 10:59 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 1, 2024 10:59 Inactive
@selankon
Copy link
Collaborator Author

selankon commented Aug 1, 2024

@elboletaire I added a link to the validator account address, I don't know if it has sense to have this info available...
92589d2

I feel like there are too much copy options in the validators list now. I'd leave them without the copies I think, since we now have a view and you can see all the details there, it's better to keep the copy buttons there only.

This approach is more on the way you propose 7a18c93

@elboletaire elboletaire merged commit 54b9752 into main Aug 1, 2024
3 checks passed
@elboletaire elboletaire deleted the f/implement-validators-info branch August 1, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase validators info
2 participants