F/styles refactor #771
Merged
F/styles refactor #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerouvi
force-pushed
the
f/styles-refactor
branch
from
f6f7e74
to
a42be37
Compare
selankon
requested changes
Sep 23, 2024
There was a problem hiding this comment.
Hey good job, could you explain a little bit more on the PR description what this PR does? Some brief phrases in order to read fast and understand on which direction this changes goes, if there are new components etc...
Also there are lots of translations without defaultValue, we can do it on the future.
selankon
requested changes
Sep 23, 2024
jpaulet
approved these changes
Sep 23, 2024
selankon
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
saas styles refactor