Implement create process form logic #774
Conversation
selankon
force-pushed
the
f/implement-create-process-form
branch
from
efb4594 to
ed3f9c2
Compare
selankon
force-pushed
the
f/implement-create-process-form
branch
from
ed3f9c2 to
fb12f7a
Compare
| @@ -16,7 +16,6 @@ export const VotingTypes = [VotingTypeSingle as VotingType, UnimplementedVotingT | |||
| export const useVotingType = (): GenericFeatureObject<VotingType> => { | |||
| const { t } = useTranslation() | |||
| return { | |||
| list: VotingTypes, | |||
| defined: import.meta.env.features.voting_type as VotingType[], | |||
There was a problem hiding this comment.
@selankon btw, it is not directly part of this PR, but there should be a convergence in the file names used to do the same thing.
For example Census/TypeSelector.tsx and the name of the current file Questions/useVotingType.ts do not coincide. Should probably choose one of the two naming forms
There was a problem hiding this comment.
I am agree with that but this affect the legacy scaffold code. We should rename it there
There was a problem hiding this comment.
TypeSelector has inherited its name from an old implementation which contained a component named TypeSelector. It certainly should be called useCensusTypes now, since it only contains a hook named that way.
There was a problem hiding this comment.
but rename it from develop or on d/saas?
selankon
force-pushed
the
f/implement-create-process-form
branch
from
330a29f to
134efa6
Compare
This PR implements some new necessary logic in order to follow new saas requirements for process creation. Related:
vocdoni/interoperability#210
vocdoni/interoperability#229
useAccountPlan, simulating a call that gives for an organization which features a plan has activated.Important!
This PR does not implement: