Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mail verification code form #778

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Conversation

selankon
Copy link
Contributor

It adds an input text to the mail verification page to copy paste the code if the user wants to do it (instead of follow the direct link sent on the email)

@selankon selankon changed the base branch from develop to d/saas September 30, 2024 11:04
@selankon selankon requested review from jpaulet and emmdim September 30, 2024 11:04
Copy link

github-actions bot commented Sep 30, 2024

@github-actions github-actions bot temporarily deployed to pull request September 30, 2024 11:06 Inactive
Copy link

github-actions bot commented Sep 30, 2024

@github-actions github-actions bot temporarily deployed to pull request September 30, 2024 11:06 Inactive
@emmdim
Copy link
Member

emmdim commented Oct 1, 2024

@selankon while technicaclly this PR is ok, from a UX perspective the fact that if you insert a wrong go then you are redirected to a new Error page and pressing the back button leads you to the inital page is problematic.

2024-10-01-165746_875x479_scrot

I would suggest to show an error in the same page that asks for the verification code, and then allowing the user to inout the code again.
cc @jpaulet

@jpaulet
Copy link
Member

jpaulet commented Oct 1, 2024

@selankon while technicaclly this PR is ok, from a UX perspective the fact that if you insert a wrong go then you are redirected to a new Error page and pressing the back button leads you to the inital page is problematic.

2024-10-01-165746_875x479_scrot

I would suggest to show an error in the same page that asks for the verification code, and then allowing the user to inout the code again. cc @jpaulet

Yes, the error should go in the same page, with the instructions to re-check the code and input it again, or a new button to ask a new code, as commented by Manos.

@selankon
Copy link
Contributor Author

selankon commented Oct 2, 2024

Totally agree. I also created a component VerifyForm to store the verify form logic sepparatelly

@github-actions github-actions bot temporarily deployed to pull request October 2, 2024 10:01 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 2, 2024 10:01 Inactive
@selankon selankon merged commit fba2e3e into d/saas Oct 2, 2024
3 checks passed
@selankon selankon deleted the f/add-mail-verification-code-form branch October 2, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants