Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create process form styles #781

Merged
merged 10 commits into from
Oct 21, 2024
Merged

Create process form styles #781

merged 10 commits into from
Oct 21, 2024

Conversation

gerouvi
Copy link
Collaborator

@gerouvi gerouvi commented Oct 7, 2024

The styles from the SAAS process are applied, creating their different variations based on the default theme.

@gerouvi gerouvi requested a review from selankon October 7, 2024 09:51
@selankon selankon changed the title create process form styles Create process form styles Oct 14, 2024
Copy link
Contributor

@selankon selankon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, this PR is huge! Try to find the way to do not rely on the import.meta.env.SAAS_URL to check if use styles for saas theme

src/components/Calculator/index.tsx Show resolved Hide resolved
src/components/Editor/styles.css Show resolved Hide resolved
src/components/ProcessCreate/Census/Spreadsheet/index.tsx Outdated Show resolved Hide resolved
src/components/ProcessCreate/Census/Spreadsheet/index.tsx Outdated Show resolved Hide resolved
src/components/ProcessCreate/Census/Web3.tsx Outdated Show resolved Hide resolved
src/components/ProcessCreate/Steps/Navigation.tsx Outdated Show resolved Hide resolved
src/components/ProcessCreate/Steps/Navigation.tsx Outdated Show resolved Hide resolved
src/elements/LayoutProcessCreate.tsx Outdated Show resolved Hide resolved
src/router/SaasProtectedRoutes.tsx Show resolved Hide resolved
src/themes/saas/index.ts Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Oct 16, 2024

@github-actions github-actions bot temporarily deployed to pull request October 16, 2024 12:25 Inactive
Copy link

github-actions bot commented Oct 16, 2024

@github-actions github-actions bot temporarily deployed to pull request October 16, 2024 12:25 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 17, 2024 15:25 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 17, 2024 15:25 Inactive
Copy link
Member

@elboletaire elboletaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks quite good, but there are a few things about the final result (which are hard to pinpoint directly in the code):

  • The process creation had the option to create both multi-question and single-type questions, but with these changes, the single-type no longer works. Please try to restore it.
  • I’m not a fan of adding buttons and features that aren’t immediately implemented. This applies to both the "approval" option added and all the new election options.
  • Speaking of that new election options section that was added, I find it quite lacking. At the very least, it should have a title. And if the options haven’t been implemented yet, it might be a good idea to set all the unimplemented options as disabled until they’re properly developed (since I understand you added them for theming purposes and want to preview them).
  • The use of color variables is quite wrong if the idea was to continue using themes... Remember, variable names for theme elements should be related to the section they belong to, rather than directly using a name like colorsBase.white.dark. But don’t worry about this—I’ll probably remove the theming system ASAP to reduce the burden it's causing on the project.

src/components/Editor/Editor.tsx Outdated Show resolved Hide resolved
src/components/ProcessCreate/Census/Spreadsheet/index.tsx Outdated Show resolved Hide resolved
src/themes/saas/components/checkbox.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request October 18, 2024 09:52 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 18, 2024 09:53 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 21, 2024 08:45 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 21, 2024 08:45 Inactive
@elboletaire elboletaire merged commit 156cfa7 into d/saas Oct 21, 2024
3 checks passed
@elboletaire elboletaire deleted the f/create-process-form-styles branch October 21, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants