-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create process form styles #781
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, this PR is huge! Try to find the way to do not rely on the import.meta.env.SAAS_URL
to check if use styles for saas theme
d766dbd
to
60a11c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks quite good, but there are a few things about the final result (which are hard to pinpoint directly in the code):
- The process creation had the option to create both multi-question and single-type questions, but with these changes, the single-type no longer works. Please try to restore it.
- I’m not a fan of adding buttons and features that aren’t immediately implemented. This applies to both the "approval" option added and all the new election options.
- Speaking of that new election options section that was added, I find it quite lacking. At the very least, it should have a title. And if the options haven’t been implemented yet, it might be a good idea to set all the unimplemented options as disabled until they’re properly developed (since I understand you added them for theming purposes and want to preview them).
- The use of color variables is quite wrong if the idea was to continue using themes... Remember, variable names for theme elements should be related to the section they belong to, rather than directly using a name like colorsBase.white.dark. But don’t worry about this—I’ll probably remove the theming system ASAP to reduce the burden it's causing on the project.
The styles from the SAAS process are applied, creating their different variations based on the default theme.