-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard, menu and dashboard voting page #793
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edit: done, and remade the dashboard menu too |
elboletaire
force-pushed
the
f/dashboard-layout
branch
from
October 25, 2024 13:06
efbe519
to
04b6a8a
Compare
elboletaire
changed the title
Dashboard and dashboard voting page
Dashboard, menu and dashboard voting page
Oct 25, 2024
jpaulet
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some considerations:
components/Dashboard
folder. The folder used for most dashboard components right now isOrganization
, which does not align with our real intentions here.DashboardContents
component to draw the main dashboard contents, orDashboardBox
to draw boxes. See ProcessView for more details on this.I haven't looked the dashboard menu.. I've just reused what we had there, but it needs a refactor too. Using individual. Remade the dashboard menu as well.setState
methods for each submenu doesn't look like the way to gouseDarkMode
one. TheDarkModeSwitcher
has been removed, and the already existingSwitchColorMode
is being used instead.useOutletContext
(see ProcessView for more details on this).