Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard, menu and dashboard voting page #793

Merged
merged 8 commits into from
Oct 28, 2024
Merged

Conversation

elboletaire
Copy link
Member

@elboletaire elboletaire commented Oct 24, 2024

Some considerations:

  • I've recreated the dashboard layout from scratch.
  • I've created a new components/Dashboard folder. The folder used for most dashboard components right now is Organization, which does not align with our real intentions here.
  • Use the DashboardContents component to draw the main dashboard contents, or DashboardBox to draw boxes. See ProcessView for more details on this.
  • I haven't looked the dashboard menu.. I've just reused what we had there, but it needs a refactor too. Using individual setState methods for each submenu doesn't look like the way to go. Remade the dashboard menu as well.
  • I've removed some components that were useless, but there are still some others that should be removed, like the useDarkMode one. The DarkModeSwitcher has been removed, and the already existing SwitchColorMode is being used instead.
  • The dashboard layout allows you to set both a title and a back button via useOutletContext (see ProcessView for more details on this).
  • I've removed the default buttons behavior, which was coloring them in green for most of the cases. A proper review/recheck of the buttons should be done when we have an actual style guide to follow.

Copy link

github-actions bot commented Oct 24, 2024

@github-actions github-actions bot temporarily deployed to pull request October 24, 2024 14:55 Inactive
Copy link

github-actions bot commented Oct 24, 2024

@github-actions github-actions bot temporarily deployed to pull request October 24, 2024 14:55 Inactive
@elboletaire
Copy link
Member Author

elboletaire commented Oct 25, 2024

Mental note: the right margin must be properly added to the layout, rather than to the view like it is right now (that's why is only displayed for the dashboard process view).

Also, review all other admin pages are properly using DashboardContents component.

Edit: done, and remade the dashboard menu too

@github-actions github-actions bot temporarily deployed to pull request October 25, 2024 09:57 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 25, 2024 09:57 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 25, 2024 10:18 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 25, 2024 10:18 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 25, 2024 13:07 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 25, 2024 13:07 Inactive
@elboletaire elboletaire changed the title Dashboard and dashboard voting page Dashboard, menu and dashboard voting page Oct 25, 2024
@github-actions github-actions bot temporarily deployed to pull request October 28, 2024 08:24 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 28, 2024 08:24 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 28, 2024 08:25 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 28, 2024 08:26 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 28, 2024 09:02 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 28, 2024 09:02 Inactive
@elboletaire elboletaire merged commit 9629fe1 into develop Oct 28, 2024
3 checks passed
@elboletaire elboletaire deleted the f/dashboard-layout branch October 28, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants