removed useDarkMode #794
Merged
removed useDarkMode #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elboletaire
requested changes
Oct 28, 2024
There was a problem hiding this comment.
I've pointed out some issues not directly related to this PR, but I wasn't aware of them (remember I've been out for a month..).
Overall you should stop using the useColorModeValue hook, and use the _dark prop instead. The hook should only be used for some specific cases where you need a value change, but for theming purposes simply use the _dark prop instead.
Also, avoid styling buttons. Buttons should only have a variant for now, any other props should be done in that variant, or maybe they should not be in that button at all.
… in input custom and checkbox custom
elboletaire
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed useDarkMode hook and use useColorModeValue in each Component