-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Account without Organization #836
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review done with @elboletaire. Check all layout elements are not LazyLoaded
Now the question here is how the "create organization" form should this be displayed. Should be open inside the dashboard layout? Or should be a single page with its own layout? Also the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the minor code changes, there are some issues with the flow right now:
- After creating an organization using an account which didn't have one related via the dashboard, the app stayed in the "create organization" form, rather than redirecting to the dashboard
- I've then (manually) accessed the dashboard, and from then trying to go to my created organization crashes
- We have to review the current signup flow to show the create organization form but allow users to skip it.
- Assess using a different layout when accessing via the dashboard than from the signup process
Now protected routes is a function that return a RouteObject
Moved Verify page to elements and use better name to verification pending form
It also implements skip button for organization form
f5c356c
to
bc49e5a
Compare
Fixes #844
This PR enables the possibility to have an account without organization and navigate through Dashboard. To do this it refactor protected routes into two different protected routes:
AccountProtectedRoute
: which check if you are logged inOrganizationProtectedRoute
: Checks that an organization is already createdIt also refactors a bit the
LayoutAuth
to be reused for theCreateOrganization
form. It implements some Outlet context setters.Either, changes a bit the UX flux:
Other relevant changes