Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tables figma #871

Merged
merged 16 commits into from
Dec 18, 2024
Merged

Tables figma #871

merged 16 commits into from
Dec 18, 2024

Conversation

gerouvi
Copy link
Collaborator

@gerouvi gerouvi commented Dec 11, 2024

Applied tables figma styles

closes #846

@gerouvi gerouvi requested a review from elboletaire December 12, 2024 09:13
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 12, 2024 •
edited
Loading

🚀 Deployed on https://6762a6deb0259fe065795eec--vocdoni-app-dev.netlify.app

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 12, 2024 •
edited
Loading

🚀 Deployed on https://6762a6d5a87a76d948acb2f9--vocdoni-app-stg.netlify.app

@github-actions github-actions bot temporarily deployed to pull request December 12, 2024 09:57 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 12, 2024 09:57 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 12, 2024 12:57 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 12, 2024 12:57 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 12, 2024 15:03 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 12, 2024 15:03 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 17, 2024 13:49 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 17, 2024 13:49 Inactive
elboletaire
elboletaire requested changes Dec 17, 2024
View reviewed changes
Copy link
Member

@elboletaire elboletaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A black border appears below the tables now, but also, you "broke" the link in the process list.
There's no way to click on the processes now and go to their view.

imatge

@github-actions github-actions bot temporarily deployed to pull request December 17, 2024 16:53 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 17, 2024 16:53 Inactive
@gerouvi gerouvi requested a review from elboletaire December 17, 2024 18:10
@github-actions github-actions bot temporarily deployed to pull request December 18, 2024 09:47 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 18, 2024 09:47 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 18, 2024 10:24 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 18, 2024 10:24 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 18, 2024 10:35 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 18, 2024 10:35 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 18, 2024 10:41 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 18, 2024 10:41 Inactive
@elboletaire elboletaire merged commit 87bae5a into develop Dec 18, 2024
3 checks passed
@elboletaire elboletaire deleted the f/table-846 branch December 18, 2024 10:42
@elboletaire elboletaire mentioned this pull request Dec 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elboletaire elboletaire elboletaire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Style Tables
2 participants
@gerouvi @elboletaire