-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Multiprocesses components #10
Draft
selankon
wants to merge
31
commits into
main
Choose a base branch
from
f/implement-multiprocess
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selankon
force-pushed
the
f/implement-multiprocess
branch
3 times, most recently
from
October 11, 2024 07:51
cd4930e
to
10501b2
Compare
elboletaire
requested changes
Oct 14, 2024
selankon
force-pushed
the
f/implement-multiprocess
branch
from
October 17, 2024 10:48
9931ff1
to
4b32a38
Compare
selankon
force-pushed
the
f/implement-multiprocess
branch
from
October 18, 2024 07:52
4b32a38
to
c4ede87
Compare
Set as draft, since the dependency is a draft too |
selankon
force-pushed
the
f/implement-multiprocess
branch
from
October 22, 2024 11:04
34d9d90
to
1010e38
Compare
And fix TS errors that appeared with the change
selankon
force-pushed
the
f/implement-multiprocess
branch
from
November 11, 2024 13:48
302e31f
to
d1f324e
Compare
To show it more similar as vote button
selankon
force-pushed
the
f/implement-multiprocess
branch
from
November 13, 2024 11:18
9063a9e
to
70cbe70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It implements necessary components to render multiple elections on the same page.
It depends on vocdoni/ui-components#204
If the metadata of chained elections contains the
RenderWith
information, it get the elections to render together.Changes:
ConfirmVoteModal
refactor to support new confirmation function parameters (now return aRecord<string, FieldValues>
. Is a dictionary of election ids with the field values)Some considerations
And should work out of the box with all other chained process and Vocdoni features.
It also changes
strict: false
ontsconfig.json
to be able to pass the lintern. For some reason this causes lintern issues on wagmi and rainbowkit configuration code, check ed3d28c for more info.