feat(dbt cloud): Changing page size #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7 +/- ##
==========================================
- Coverage 76.11% 76.05% -0.07%
==========================================
Files 16 16
Lines 381 380 -1
Branches 51 51
==========================================
- Hits 290 289 -1
Misses 78 78
Partials 13 13 ☔ View full report in Codecov by Sentry. |
fernandobrito
approved these changes
Nov 23, 2023
gabby-dol
deleted the
DATAPS-1479-change-default-value-for-page-size-in-dbt-toolkit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, page_size is set to 500. According to the dbt announcement email (search for Action required: API Request Limits in dbt Cloud in your inbox), from December 2023, it will only return 100 records. So, we need to change the default value for page_size to 100.