Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow editing of audioQuery #45

Merged
merged 1 commit into from
Sep 17, 2023
Merged

Allow editing of audioQuery #45

merged 1 commit into from
Sep 17, 2023

Conversation

ryunix
Copy link
Contributor

@ryunix ryunix commented Sep 17, 2023

Before the change, the new speedScale was not used.

Example:

const audioQuery = await client.createAudioQuery("こんにちは", 0);
console.log(audioQuery.speedScale);  // => 1
audioQuery.speedScale = 2;
await audioQuery.synthesis(0);  // Generated with speedScale=1

After the change, the new speedScale will be used.
This behavior is the same as voicevox-client/python.

@tuna2134
Copy link
Member

LGTM!
Thanks

@tuna2134 tuna2134 merged commit 5dbf773 into voicevox-client:main Sep 17, 2023
2 checks passed
@ryunix ryunix deleted the allow-editing-of-audio-query branch September 18, 2023 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuna2134 tuna2134 tuna2134 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryunix @tuna2134