-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
salt: update to 3007.1. #52887
base: master
Are you sure you want to change the base?
salt: update to 3007.1. #52887
Conversation
Forgot to CC the maintainer, I do apologize: @Vaelatern |
Ah, the suite contains a check for i686. |
We need to add more patches for the most recent python we are running. Yes this patch is still needed on 3006.8 >.> but figuring out what works is hard. Good news is I have a broken Salt install I'll test this PR on :) |
Thanks for the useful input! And for testing :) Looking forward to your findings, particularly the stuff that breaks. I'll have a go at basic tests, this time with both minion+master on Void. |
Yeah, I've tested and the patch I mentioned isn't enough yet... |
Ok I got it functional for python 3.12 but 3.13 is on the horizon. |
Closes: void-linux#52887 [via git-merge-pr]
My branch is here https://github.com/Vaelatern/void-packages/tree/salt-3007 I want to test a master/minion setup with this too. Also want to test with python 3.13 and fix it up for that, in advance of the upcoming python3.13 bump @ahesford (I think you're doing that?) |
Yes, my intention is to push Python tomorrow. |
Have you needed to make any changes to salt that I should be aware of so that I can incorporate Py 3.13 into salt? |
No, salt builds as-is on my branch. |
Confirming that this does not presently work with python 3.13. It was broken before, but there are more changes necessary to salt for the newest Python. EDIT: It works but there is a need for a patch we don't yet have, to |
saltstack/salt#67119 |
Closes: void-linux#52887 [via git-merge-pr]
Testing the changes
salt-minion
is successful, including connection to an existingsalt-master
.salt-master
from this build is untested.Local build testing
Additional notes
xlint template
: ok3006.8
.