-
Notifications
You must be signed in to change notification settings - Fork 972
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #3065 from lowang-bh/docs
add docs about un-enqueueable reason
- Loading branch information
Showing
1 changed file
with
25 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
# podgroup conditions | ||
|
||
## Backgrounds | ||
|
||
Currently, there are only two podgroup condition type: `Unschedulable` and `Scheduled`. If job is not enqueued, it has not been scheduled. And the event reason is `Unschedulable` and podgroup condition reason is `NotEnoughResources`. These reasons is not coresponding with the real reason `job is not enqueued` | ||
|
||
## Motivation | ||
|
||
In order to classify the uninqueueable reason from other unscheduleable reasons | ||
|
||
## Design | ||
|
||
1. add `Uninqueueable` reason for podgroup events | ||
|
||
```go | ||
// PodGroupUnInqueueable is Uninqueueable event type | ||
PodGroupUnInqueueable PodGroupConditionType = "Uninqueueable" | ||
``` | ||
|
||
2. add `NotInqueueable` reason for podgroup conditions reason | ||
|
||
```go | ||
// NotInqueueableReason if probed if job is rejected to enqueue | ||
NotInqueueableReason string = "NotInqueueable" | ||
``` |