-
Notifications
You must be signed in to change notification settings - Fork 971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cherry-pick important bugfix to release-1.8 branch for v1.8.x #3027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikita <[email protected]>
Signed-off-by: william-wang <[email protected]>
Signed-off-by: lowang_bh <[email protected]>
Signed-off-by: wulixuan <[email protected]>
Signed-off-by: wulixuan <[email protected]>
…tes/finalizers permission for jobflow controller Signed-off-by: mazhongbao <[email protected]>
Signed-off-by: Tongruizhe <[email protected]>
volcano-sh-bot
requested review from
hudson741,
hzxuzhonghu,
merryzhou and
shinytang6
August 2, 2023 08:23
volcano-sh-bot
added
the
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
label
Aug 2, 2023
william-wang
removed request for
merryzhou,
hudson741,
hzxuzhonghu and
shinytang6
August 2, 2023 08:24
Thor-wl
approved these changes
Aug 3, 2023
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Thor-wl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Aug 3, 2023
Signed-off-by: Ren <[email protected]>
Signed-off-by: Ren <[email protected]>
Signed-off-by: Ren <[email protected]>
volcano-sh-bot
added
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
and removed
lgtm
Indicates that a PR is ready to be merged.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
Aug 4, 2023
Signed-off-by: william-wang <[email protected]>
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.