Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct spelling errors in comments and unify the package to apis/scheduling #3069

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

lowang-bh
Copy link
Member

@lowang-bh lowang-bh commented Aug 26, 2023

commit 1: correct spelling errors in comments.
commit 2: use volcano.sh/apis/pkg/apis/scheduling
There are packages volcano.sh/apis/pkg/apis/scheduling and volcano.sh/apis/pkg/apis/scheduling/v1beta1.
we'd better only use latest volcano.sh/apis/pkg/apis/scheduling

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 26, 2023
@lowang-bh lowang-bh changed the title Docs unify the package to latest volcano.sh/apis/pkg/apis/scheduling Aug 26, 2023
@volcano-sh-bot volcano-sh-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 26, 2023
@lowang-bh
Copy link
Member Author

/assign @hwdef @wangyang0616 @Thor-wl @william-wang

@lowang-bh lowang-bh changed the title unify the package to latest volcano.sh/apis/pkg/apis/scheduling correct spelling errors and unify the package to latest volcano.sh/apis/pkg/apis/scheduling Aug 28, 2023
@lowang-bh lowang-bh changed the title correct spelling errors and unify the package to latest volcano.sh/apis/pkg/apis/scheduling correct spelling errors and unify the package to apis/scheduling Aug 28, 2023
@lowang-bh lowang-bh changed the title correct spelling errors and unify the package to apis/scheduling correct spelling errors in comments and unify the package to apis/scheduling Aug 28, 2023
Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2023
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2023
@volcano-sh-bot volcano-sh-bot merged commit 9a96046 into volcano-sh:master Sep 15, 2023
12 checks passed
@lowang-bh lowang-bh deleted the docs branch September 16, 2023 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants